Skip to content

Conversation

@mbutrovich
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

We're not running TPC-DS plan checks in CI: #2469
I think #2429 introduced new plans, but we didn't catch it. This fixes the plans in main.

How are these changes tested?

https://datafusion.apache.org/comet/contributor-guide/development.html#plan-stability-testing

@mbutrovich mbutrovich changed the title Update TPS-DC plans after #2429. chore: update TPS-DC plans after #2429 Sep 29, 2025
@mbutrovich mbutrovich changed the title chore: update TPS-DC plans after #2429 chore: update TPS-DS plans after #2429 Sep 29, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.41%. Comparing base (f09f8af) to head (732afa1).
⚠️ Report is 550 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2486      +/-   ##
============================================
+ Coverage     56.12%   58.41%   +2.28%     
- Complexity      976     1436     +460     
============================================
  Files           119      146      +27     
  Lines         11743    13510    +1767     
  Branches       2251     2350      +99     
============================================
+ Hits           6591     7892    +1301     
- Misses         4012     4389     +377     
- Partials       1140     1229      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mbutrovich mbutrovich added this to the 0.11.0 milestone Sep 29, 2025
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbutrovich

@mbutrovich mbutrovich merged commit 4ec8010 into apache:main Sep 29, 2025
106 of 108 checks passed
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants